-
Type:
Story
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.11 Larks
-
Fix Version/s: None
-
Labels:None
-
Sprint:3.12 Larks
As Admin i want to be able to manage filters for restricted mail domains and ip-addresses
- There is new item "Spam protection" in administration menu.
- After clicking it page with spam protection settings is opened
- Page contains:
- "Spam protection setting" title
- "Add rule" button
- Table with available rules:
- Rule column
- Description column
- Enabled column
- If Administartor wants to add new rule - she presses "Add rule" button. Popup with "Rule regex" and "Rule description" inputs, "Save" and "Cancel" buttons is displayed. Validation rules for:
- "Rule regex" input - 1..255 characters
- "Rule description" - 0..255 characters
- Table with already created rules doesn't have pagination. All rules should be displayed.
- When administrator hovers row "Edit" and "Remove" icons are displayed (same as for user groups).
- When user clicks "Edit" icon - same popup as for adding rule is displayed, fields are filled with values from selected rule. If admin saves rule - changes are applying for selected rule.
- When administrator clicks on "Remove" icon confirmation popup is displayed. If user clicks on "OK" in popup - rule is deleted.
- If email from user registration matches any rule - user should not be registered and pop up with error message for email field is shown. User registration data should be logged.
Localization:
| Item | EN | RU | UA |
|---|---|---|---|
| Menu item | Spam protection | Защита от спама | Захист від спаму |
| Enabled column | Enabled | Включено | Ввімкнено |
| Rules column | Rules | Правила | Правила |
| Description columns | Descriptions | Описания | Описи |
| Add rule popup title | New rule | Новое правило | Нове правило |
| Add rule popup button text | Add rule | Добавить правило | Додати правило |
| Edit rule popup title | Edit rule | Редактировать правило | Редагувати правило |
| Regex placeholder | Rule regex | Регулярное выражение для правила | Регулярний вираз для правила |
| Description placeholder | Rule description | Описание правила | Опис правила |
| Remove rule confirmation | Are you sure you want to delete this rule? | Вы уверены, что хотите удалить это правило? | Ви впевнені, що бажаєте видалити це правило? |
| Matching block rule message | Sorry, you use restricted email. If you are not a bot - write to administrator (email at the bottom of every page). | Простите, вы используете запрещенный адрес электронной почты. Если вы не бот - напишите администратору (адрес почты внизу каждой страницы). | Вибачте, ви використовуєте заборонену адресу електронної пошти. Якщо ви не бот - напишіть адміністратору (адреса пошти внизу кожної сторінки). |
| Empty/too long Rule regex error message | Rule regex length must be between 1 and 255 characters | Длина регулярного выражения должна быть между 1 и 255 символами | Довжина регулярного виразу повинна бути від 1 до 255 символів |
| Too long Rule description error message | Rule description length must be between 1 and 255 characters | Длина описания правила должна быть между 0 и 255 символами | Довжина опису правила повинна бути від 0 до 255 символів |
| Invalid regex error message | Error_message near index Index_number | Error_message near index Index_number | Error_message near index Index_number |
Found bugs
| Description | Status for Build 3163 | Status for Build 3169 | Status for Build 3171 | Link |
|---|---|---|---|---|
| Wrong title for Edit Rule pop up |  |
|
 |
link |
| Grammar mistake in New Rule pop up title(EN) | |
|
|
link |
| Grammar mistake in remove rule confirmation pop up (RU) | |
|
|
link |
| Change error message for Rule regex field and rule description field | |
|
|
link |
| Possible to save Rule with only spaces entered into regex column | |
|
|
link |
| TAB doesn't move focus to New Rule pop up x button | |
|
|
link |
| Wrong focus order for Remove rule confirmation pop up | |
|
|
link |
| When focus is on x button on Remove rule confirmation pop up and ENTER is pressed rule is deleted | |
|
|
link |
| Checkbox and icon are not on the same line | |
|
|
link |
| Long rule/description leads to horizontal scroll | |
|
|
link |
| Remove tooltips for Enabled checkbox activation/deactivation | |
|
|
link |
| Spaces are not completely trimmed after text in "Rule regex" and "Rule description" fields. | |
|
|
link |
| Spaces are not completely trimmed before text in "Rule regex" and "Rule description" fields. | |
|
|
link |
| Not possible to focus Edit rule and Delete rule icons with TAB | |
|
Won't fix | link |
| Wrong error message when trying to activate/deactivate Enabled checkbox by Anonymous user | |
|
|
link |
| Wrong error message when trying to add New rule by Anonymous user | |
|
|
link |
| Unexpected error during registration instead of per-field validation | |
|
|
link |
| Index number in regex pattern error message starts not from zero | |
Won't fix: link | link | |
| Html validation errors on Spam protection page | |
: link |
link |
- Testing discovered
-
JC-2404 Html validation errors on Spam protection page
-
- Open
-
Wrong title for Edit Rule pop up
Build: 3.12.3163.06aa001 (QA)
Preconditions: You should have at least one Rule available on your Spam protection settings table
Steps to reproduce:
- Choose English localization for Forum
- Go to Administration ->Spam protection and click on Edit rule icon for your Rule
- Overview pop up title
Actual result: Title is new Rule
Expected result: Title should be Edit rule
Same wrong title for RU and UA localization
Grammar mistake in New Rule pop up title(EN)
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
- Choose English localization for Forum
- Go to Administration ->Spam protection and click on "Add rule" button
- Overview pop up title
Actual result: Title is new Rule
Expected result: : Title should be New rule
Grammar mistake in remove rule confirmation pop up (RU)
Build: 3.12.3163.06aa001 (QA)
Preconditions: You should have at least one Rule available on your Spam protection settings table
Steps to reproduce:
- Choose Russian localization for Forum
- Go to Administration ->Spam protection and click on Remove rule icon for your Rule
- Overview confirmation pop up text.
Actual result: Text is Вы уверены, что хотите удалить т это правило?
Expected result: : Title should be Вы уверены, что хотите удалить это правило?
Change error message for Rule regex field and rule description field
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
- Go to Administration ->Spam protection and click on "Add rule" button
- Enter text te that is more than 255 characters long into both Rule regex and Rule description fields and click on Save button
Actual result:
Following error message appear:
length must be between 1 and 255 for Rule regex field.
length must be between 0 and 255 for Rule description field.
Expected result:
Error messages should be following:
Rule regex length must be between 1 and 255 characters for Rule regex field.
Rule description length must be between 0 and 255 characters for Rule description field.
Error message should be changed for Regex and description fields for Edit rule pop up as well
Possible to save Rule with only spaces entered into regex column
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
- Go to Administration ->Spam protection and click on "Add rule" button
- Type several spaces in Rule regex field and click on Save button
Actual result: Rule is saved with empty Rule regex field
Expected result: Rule is not saved. Error message Rule regex length must be between 2 and 255 characters should be shown.
Same behaviour is reproduced for Edit rule pop up
TAB doesn't move focus to New Rule pop up x button.
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
- Go to Administration ->Spam protection and click on "Add rule" button
- Press TAB several times and overview how focus is moved
Actual results: Focus is moved to Rule regex field > Rule Description field > Save button > Cancell button and not moved to x button.
Expected results: Focus is moved to Rule regex field > Rule Description field > Save button> Cancell button->x button
Same behaviour is reproduced for Edit rule pop up
Wrong focus order for Remove rule confirmation pop up
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
Preconditions: You should have at least one Rule available on your Spam protection settings table
Steps to reproduce:
- Go to Administration ->Spam protection and click on Remove rule icon for your Rule
- Press TAB several times and overview how focus is moved
Actual results: Focus is moved to OK button > x button> Cancell button > OK button > Browser address and search bar
Expected results: Focus is moved to OK button > Cancell button->x button
When focus is on x button on Remove rule confirmation pop up and ENTER is pressed rule is deleted
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
Preconditions: You should have at least one Rule available on your Spam protection settings table
Steps to reproduce:
- Go to Administration ->Spam protection and click on Remove rule icon for your Rule
- Press TAB several times till focus is on x button and press ENTER
Actual results: Confirmation pop up is closed. Rule is deleted
Expected results: Confirmation pop up is closed. Rule is not deleted
It was decided that regex validation for Rule regex field on New rule and Edit rule pop up should be added.
Error message for invalid regex input was added to story description.
Issue should be reopened
Checkbox and icon are not on the same line
Steps to reproduce
- Choose EN language on lang menu
- Go to Administration ->Spam protection and hover any row with existing rule
Actual result
Checkbox "Enabled" and "Edit"/"Remove" icon are not on one horizontal line
Expected result
Checkbox and icons should be on the same line
Long rule/description leads to horizontal scroll
Steps to reproduce
- Add rule with 255 symbols regex and 255 symbols description
Actual result
Rule is added, horizontal scroll is appeared
Expected result
Rule is added, there is no horizontal scroll
Remove tooltips for Enabled checkbox activation/deactivation
Steps to reproduce:
1. Click on activated Enabled checkbox to deactivate it and vice versa
Actual results:
"Rule is activated" / "Rule is diactivated" tooltips are shown.
Expected results:
No tooltips should be shown.
Spaces are not completely trimmed after text in "Rule regex" and "Rule description" fields.
Steps to reproduce:
- Go to Administration ->Spam protection and click on "Add rule" button
- Type some text and several spaces after it in Rule regex and Rule description fields and click on Save button
- Press on Edit rule icon for the Rule you have created in step #3
- Overview Rule regex and Rule description fields
Actual result: One space is not trimmed after text on both fields
Expected result: All spaces should be trimmed after text in Rule regex and Rule description fields
Spaces are not completely trimmed before text in "Rule regex" and "Rule description" fields.
Steps to reproduce:
- Go to Administration ->Spam protection and click on "Add rule" button
- Type some text and several spaces before it in Rule regex and Rule description fields and click on Save button
- Press on Edit rule icon for the Rule you have created in step #3
- Overview Rule regex and Rule description fields
Actual result: One space is not trimmed before the text on both fields
Expected result: All spaces should be trimmed before the text in Rule regex and Rule description fields
Not possible to focus Edit rule and Delete rule icons with TAB
Build: 3.12.3163.06aa001 (QA)
Preconditions: You should have at least one Rule available on your Spam protection
Steps to reproduce:
- Go to Administration ->Spam protection and press TAB several times and overview how focus is moved
Actual result: Focus is moved first to "Add rule" button and then to Enabled checkbox of the Rule only. Edit rule and Delete rule icons are not visible and are not focused with TAB. Selected rule is not highlighted in blue.
Expected result: Once Focus is moved to Enabled checkbox of the Rule, Edit rule and Delete rule icons of this rule should become visible and Rule raw should become highlighted in blue. Focus should move through Enabled checkbox -> Edit icon - > Delete icon of each rule.
Wrong error message when trying to activate/deactivate Enabled checkbox by Anonymous user
Build: 3.12.3163.06aa001 (QA)
Preconditions: You should have at least one Rule available on your Spam protection page
Steps to reproduce:
- Open Forum on Tab#1, login as User with Administrator permissions
- Go to Administration ->Spam protection
- Open Forum on Tab#2 and logout
- Return to Tab#1 and try to activate/deactivate Enabled checkbox of the Rule.
Actual result: Pop up with error 500 message is shown: We're sorry! The server encountered an internal error or misconfiguration and was unable to complete your request.
Expected result:Pop up with error 403 message should be shown: Access denied. You don't have enough privileges to access this resource or perform this operation. Ensure you have enough privileges or go to forum main page.
Same error message is shown when trying to Edit rule and Delete rule as Anonymous user and when trying to Add, Edit, Delete rule and activate/deactivate checkbox as user w/o Administrator permissions.
Wrong error message when trying to add New rule by Anonymous user
Build: 3.12.3163.06aa001 (QA)
Steps to reproduce:
- Open Forum on Tab#1, login as User with Administrator permissions
- Go to Administration ->Spam protection and click on "Add rule" button.
- Fill out fields with valid data
- Open Forum on Tab#2 and logout
- Return to Tab#1 and click on Save button.
Actual result: Pop up with no error message is shown.
Expected result: Pop up with error 403 message should be shown: Access denied. You don't have enough privileges to access this resource or perform this operation. Ensure you have enough privileges or go to forum main page.
Unexpected error during registration instead of per-field validation
Environment
JCommune 3.12.3166.9a8bf28
Steps to reproduce
1. Open registration form
2. Leave all fields empty and press "Sign up"
Actual result
Registration form is closed, popup with "Unexpected error during registration" is shown
Expected result
All fields should have own validation message, sign up pop up shouldn't be closed
Index number in regex pattern error message starts not from zero
Build: 3.12.3169.29003f6 (QA)
Test Scenario#1:
Steps to reproduce:
- Open Forum on Tab#1, login as User with Administrator permissions.
- Go to Administration ->Spam protection and click on "Add rule" button.
- Enter symbol ( into Rule regex firld and and click on "Save" button.
Actual result: error message " Unclosed group near index 1" is shown.
Expected result: error message " Unclosed group near index 0" is shown.
Test Scenario#2:
Steps to reproduce:
- Open Forum on Tab#1, login as User with Administrator permissions
- Go to Administration ->Spam protection and click on "Add rule" button.
- Enter symbol ) into Rule regex field and and click on "Save" button.
Actual result: error message " Unmatched closing ')' near index -1" is shown.
Expected result: error message "Unmatched closing ')' near index 0" is shown.
Html validation errors on Spam protection page
Build: 3.12.3169.29003f6 (QA)
Steps to reproduce:
- Login to Forum as User with Administrator permissions.
- Go toGo to Administration ->Spam protection.
- Copy source code of the page, paste it on http://validator.w3.org and validate page.
Actual results: Validator shows few errors.
Expected results: Validator should show no errors
List of open bugs for built 3.12.3169 was added to issue description. Issue should be reopened
Natalia Boryakova I've discussed with Stanislav Bashkyrtsev about Index number in regex pattern error message starts not from zero issue, and we decided to leave it as is because this functionality will be used by admins who have enough knowledge to recognize this error message.
SUCCESS: Integrated in 
JC-UnitTests #3171
JC-2390 fix (oatkachenko: 84d20db08820791cbcbc8f12cc382809e796f12c)
Build: 3.12.3171.84d20db (QA)
Browsers: Chrome, FF.
Test Scenario: See Structure
Test Results: Separate issue was created for found bug, see issue description. Issue can be closed
needed code review.