JCommuneIcon indicating the project type

JCommune

Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-906 View_Topic permission improvements
  3. JC-916

Branches without VIEW_TOPIC permission should not be available on moving topic

    Details

    • Sprint:
      1.7 Larks, 1.8 Larks, 1.9 Larks, 2.1 Larks

      Description

      Branches without VIEW_TOPIC permission (and section if users have no branches in this section to VIEW) shouldn't be shown for user in Move Topic dialog.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JC-1351 Display only visible branches in move topic dialog

          • Major - Major loss of function.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JC-906 View_Topic permission improvements

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. JC-1205 Rewrite Move Topic dialog

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JC-1485 Current branch is shown on moving Code Review

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Test - Automated or manual test JC-549 [Test] Move topic between sections/branches

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Waiting for Review
          Testing discovered

          Bug - A problem which impairs or prevents the functions of the product. JC-1638 Section with hidden branches is shown in the Move Topic dialog

          • Major - Major loss of function.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sptp Andrey Pogorelov added a comment -

            Fixed choice of available branches and sections for move topic action depending on VIEW_TOPIC permission.

            Show
            sptp Andrey Pogorelov added a comment - Fixed choice of available branches and sections for move topic action depending on VIEW_TOPIC permission.
            Hide
            Permalink
            ctapobep Stanislav Bashkyrtsev added a comment -

            There are already placed in JCommune that choose whether user should see branches or not. E.g. when user opens a new page. I don't think you should implement your custom logic, rather we should reuse existing code.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - There are already placed in JCommune that choose whether user should see branches or not. E.g. when user opens a new page. I don't think you should implement your custom logic, rather we should reuse existing code.
            Hide
            Permalink
            savgur Guram Savinov added a comment - - edited

            Stanislav Bashkyrtsev:

            E.g. when user opens a new page.

            You mean main JCommune page? Or branches list page?

            I don't think you should implement your custom logic, rather we should reuse existing code.

            It's PermissionService to check VIEW_TOPIC permissions, I think we should reuse it.

            Show
            savgur Guram Savinov added a comment - - edited Stanislav Bashkyrtsev : E.g. when user opens a new page. You mean main JCommune page? Or branches list page? I don't think you should implement your custom logic, rather we should reuse existing code. It's PermissionService to check VIEW_TOPIC permissions, I think we should reuse it.
            Hide
            Permalink
            ctapobep Stanislav Bashkyrtsev added a comment -

            Guram Savinov, could you please have a look at jcommune/jcommune-view/jcommune-web-view/src/main/webapp/WEB-INF/tags/isSectionVisible.tag? I think that might be an answer.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - Guram Savinov , could you please have a look at jcommune/jcommune-view/jcommune-web-view/src/main/webapp/WEB-INF/tags/isSectionVisible.tag ? I think that might be an answer.
            Hide
            Permalink
            julik Julia Atlygina added a comment - - edited

            Test Enviroment: Chrome 30, build #1622

            Test Scenario:

            • Branches with Allowed view permission are visible on moving topics
            • Branches without Allowed view permission are not visible on moving topics
            • Branches with Restricted view permission are not visible on moving topics
            • Section without branches with allowed view permissions are not visible on moving topic (failed, see JC-1638)

            Regression: Moving topic permission, view for registered and anonym users
            Test Results: Separate issue JC-1638 created.

            Show
            julik Julia Atlygina added a comment - - edited Test Enviroment: Chrome 30, build #1622 Test Scenario: Branches with Allowed view permission are visible on moving topics Branches without Allowed view permission are not visible on moving topics Branches with Restricted view permission are not visible on moving topics Section without branches with allowed view permissions are not visible on moving topic (failed, see JC-1638 ) Regression: Moving topic permission, view for registered and anonym users Test Results : Separate issue JC-1638 created.

              People

              • Assignee:
                julik Julia Atlygina
                Reporter:
                julik Julia Atlygina
              • Votes:
                1 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 7h Original Estimate - 7h
                  7h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 15h
                  15h

                    Structure Helper Panel