Details

    • Type: Story
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Penguins
    • Fix Version/s: 2.4 Penguins
    • Labels:
      None
    • Sprint:
      2.4 Penguins

      Description

      As an Admin I'd like to be able to put any JS/HTML I want on top and in the bottom of pages so that I'm able to post adds/counters there

      Acceptance Tests:

      • Given I'm in Admin mode, I can see buttons "Add Custom HTML/JS" in each highlighted box (see attached)
      • Given I've added HTML/JS, it is displayed on each page (including admin pages).
      • Given I've opened editing form, I have Cancel and Save buttons.

      Criteria on labels:

      • If banner is empty, then button on page should be labeled with 'Add Custom HTML/JS'
      • If banner is not empty, then button on page should be labeled with 'Edit Custom HTML/JS'
      • In modal dialog for banner uploading there is always Save and Cancel buttons, they don't change labels.
      • Dialog title: Paste your HTML/JavaScript here:

        Attachments

          Issue Links

          Structure

          (does not include ANTARCTICLE-165)
          History

            Activity

            Hide
            jk1 Evgeniy Naumenko added a comment -

            What's about using sidebars (left and right) for that? this way we'll be able to collapse ads on small screen, preserving valuable site content

            Show
            jk1 Evgeniy Naumenko added a comment - What's about using sidebars (left and right) for that? this way we'll be able to collapse ads on small screen, preserving valuable site content
            Hide
            ctapobep Stanislav Bashkyrtsev added a comment -

            Let's have this basic implementation for now, if in the future we need to add another banner on the side, that should be a small change, right?
            Also, I don't know whether removing ads is a good idea since customers might pay for that.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - Let's have this basic implementation for now, if in the future we need to add another banner on the side, that should be a small change, right? Also, I don't know whether removing ads is a good idea since customers might pay for that.
            Hide
            jk1 Evgeniy Naumenko added a comment -

            Implementation note: please use ApplicationProperties as a database storage

            Show
            jk1 Evgeniy Naumenko added a comment - Implementation note: please use ApplicationProperties as a database storage
            Hide
            jenkins Jenkins Bot added a comment -

            SUCCESS: Integrated in Ant. Run Tests #518
            ANTARCTICLE-165 custom JS/Html on the page (jk1: 2e952b53de413d626a6cc818bd0c99f954a19463)

            Show
            jenkins Jenkins Bot added a comment - SUCCESS: Integrated in Ant. Run Tests #518 ANTARCTICLE-165 custom JS/Html on the page (jk1: 2e952b53de413d626a6cc818bd0c99f954a19463 )
            Hide
            jenkins Jenkins Bot added a comment -
            Show
            jenkins Jenkins Bot added a comment - SUCCESS: Integrated in Ant. Run Tests #521 ANTARCTICLE-165 (Evgeny.Naumenko: e58d021c32ad93a7bf64668082a6a452362feced )
            Hide
            jenkins Jenkins Bot added a comment -

            SUCCESS: Integrated in Ant. Run Tests #526
            ANTARCTICLE-165 custom JS/Html on the page (jk1: 1c8089fd80b3b0f6849ff220831bbf3be75bcc21)

            Show
            jenkins Jenkins Bot added a comment - SUCCESS: Integrated in Ant. Run Tests #526 ANTARCTICLE-165 custom JS/Html on the page (jk1: 1c8089fd80b3b0f6849ff220831bbf3be75bcc21 )
            Hide
            jk1 Evgeniy Naumenko added a comment -

            Implemented a bit differently from description above using external editor. External editor allows user to fix content, that unintentionally breaks site markup. Implementation may still be a subject of further improvements, but I prefer to resolve it as is, not to extend iteration anymore.

            Show
            jk1 Evgeniy Naumenko added a comment - Implemented a bit differently from description above using external editor. External editor allows user to fix content, that unintentionally breaks site markup. Implementation may still be a subject of further improvements, but I prefer to resolve it as is, not to extend iteration anymore.
            Hide
            xcandlelight Yuliya Selyugina added a comment -

            Test Environment
            Antarcticle 2.4.532.ef5112d
            Firefox 31.0, Chrome 37.0, Opera 12.17, Opera 24.0

            Test results:
            issue can be closed

            Show
            xcandlelight Yuliya Selyugina added a comment - Test Environment Antarcticle 2.4.532.ef5112d Firefox 31.0, Chrome 37.0, Opera 12.17, Opera 24.0 Test results: issue can be closed

              People

              • Assignee:
                xcandlelight Yuliya Selyugina
                Reporter:
                ctapobep Stanislav Bashkyrtsev
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Structure Helper Panel