Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1090

Post: Image viewed in overlay causes user to press browser "Back" button 2 times instead of once

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20 Larks, 3.5 Larks
    • Fix Version/s: 3.5 Larks
    • Labels:
      None
    • Sprint:
      1.1 Larks, 3.5 Larks

      Description

      How to reproduce:
      1. Create a topic and add a picture there with [img] bb code
      2. Open the topic, click the image -> Image is opened in overlay
      3. Close image view by pressing the X button
      4. Press browser "Back" button

      AR: User has to press "Back" 2 times before previous page will be opened
      ER: User presses "Back" button one time and the previous page is opened

      Note:

      • Reproduced for any browser (I tried Chrome, FF)
      • On each click URLs are changed, but user stays on the same page in the same state

        Attachments

        Structure

        (does not include JC-1090)
        History

          Activity

          Hide
          res Nayil added a comment -

          1.When user clicks on image the "PrettyPhoto" lib can either make new URL or not. This parameter is configurable.

          2.when user want to get back on the page, current "PrettyPhoto" lib get incoorect result.
          hashtag = (url.indexOf('#!prettyPhoto')) ? true : false; - always return true.
          For resolving this problem I install newest version of the lib.

          Show
          res Nayil added a comment - 1.When user clicks on image the "PrettyPhoto" lib can either make new URL or not. This parameter is configurable. 2.when user want to get back on the page, current "PrettyPhoto" lib get incoorect result. hashtag = (url.indexOf('#!prettyPhoto')) ? true : false; - always return true. For resolving this problem I install newest version of the lib.
          Hide
          ctapobep Stanislav Bashkyrtsev added a comment -

          Nayil, why do we have Facebook/Twitter buttons in the new img dialog? Can we switch them off?

          Show
          ctapobep Stanislav Bashkyrtsev added a comment - Nayil , why do we have Facebook/Twitter buttons in the new img dialog? Can we switch them off?
          Hide
          res Nayil added a comment -

          I've deleted unnecessary social link.
          Done

          Show
          res Nayil added a comment - I've deleted unnecessary social link. Done
          Hide
          jenkins Jenkins Bot added a comment -

          SUCCESS: Integrated in JC-UnitTests #3032
          JC-1090 Image viewed in overlay causes user to press browser 'Back' (nfatykhov82: 7deceb5560bbe552b98099ea4c2cee5045a016e4)

          Show
          jenkins Jenkins Bot added a comment - SUCCESS: Integrated in JC-UnitTests #3032 JC-1090 Image viewed in overlay causes user to press browser 'Back' (nfatykhov82: 7deceb5560bbe552b98099ea4c2cee5045a016e4 )
          Hide
          Cragon Dmitry Bashilov added a comment -

          Environment: JCommune 3.4.3033.ff2b66d (QA);
          Opera 35.0.2066.37, Chrome 48.0.2564.109 m, Firefox 44.0.2.
          Test scenario:
          1. Create a topic and add a picture there with [img] bb code (http://qa.jtalks.org/jcommune/search/?text=проба3);
          2. Open the topic (for example "Проба3"), click the image -> Image is opened in overlay;
          3. Close image view by pressing the X button;
          4. Press browser "Back" button.
          AR=ER: User presses "Back" button one time and the previous page is opened.
          Test result: The issue can be closed.

          Show
          Cragon Dmitry Bashilov added a comment - Environment : JCommune 3.4.3033.ff2b66d (QA); Opera 35.0.2066.37, Chrome 48.0.2564.109 m, Firefox 44.0.2. Test scenario : 1. Create a topic and add a picture there with [img] bb code ( http://qa.jtalks.org/jcommune/search/?text=проба3 ); 2. Open the topic (for example "Проба3"), click the image -> Image is opened in overlay; 3. Close image view by pressing the X button; 4. Press browser "Back" button. AR=ER : User presses "Back" button one time and the previous page is opened. Test result : The issue can be closed.
          Hide
          Cragon Dmitry Bashilov added a comment -

          As regression was checked the following (as I see for my own opinion):
          1. Main functionality (such as creating a new topic, adding a picture, adding a message);
          2. Main buttons for editting in a topic.
          3. Changing a language - was a bug with error 400.
          4. Bb code checking.

          Show
          Cragon Dmitry Bashilov added a comment - As regression was checked the following (as I see for my own opinion): 1. Main functionality (such as creating a new topic, adding a picture, adding a message); 2. Main buttons for editting in a topic. 3. Changing a language - was a bug with error 400 . 4. Bb code checking.

            People

            • Assignee:
              Cragon Dmitry Bashilov
              Reporter:
              kitsune Polina
            • Votes:
              1 Vote for this issue
              Watchers:
              Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel