Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-113

org/jtalks/jcommune/service/nontransactional/SecurityServiceImpl.java: use placeholders from slf4j

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.3
    • Fix Version/s: 0.4
    • Labels:
      None
    • Environment:

      Default

      Description

      (Initially created as http://fisheye.jtalks.org/cru/JC-45 but I don't know it is visible for all or not, so I create this ticket.)

      One idea about this line: https://github.com/jtalks-org/jtalks/commit/c9eefeef9ebd0b97e40c390824c107e7171ff6c5#L1R174

      If we are using slf4j so why not use placeholders which made code more readable and faster in some circumstances?

      So, instead of

      >logger.debug("Deleted securedObject " + clazz + " with id: " + id);

      I suggest to write

      >logger.debug("Deleted securedObject {} with id: {}", clazz, id);

      See http://www.slf4j.org/faq.html#logging_performance

      (Also, this probably should me changed in all source base.)

        Attachments

          Structure

            Activity

              People

              • Assignee:
                jk1 Evgeniy Naumenko
                Reporter:
                php-coder Slava Semushin
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h

                    Structure Helper Panel