Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1506

Refactor MentionedUsers class

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: tech debt
    • Fix Version/s: 2.8 Larks
    • Labels:
      None

      Description

      Problems:

      • Class violates SRP, cause it does many things.
      • It has not clear name, that doesn't describe intent of this class.
      • Objects of this class is created by calling static factory method. It's clear violation of general rule of Dependency Injection, cause client component should know how create service component. Also it increases complexity of testing.

        Attachments

          Structure

            Activity

              People

              • Assignee:
                ctapobep Stanislav Bashkyrtsev
                Reporter:
                shogun Anuar Nurmakanov
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Structure Helper Panel