Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1834

Updating favicon to pass validation

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6 Larks
    • Fix Version/s: 2.6 Larks
    • Labels:
      None
    • Sprint:
      2.6 Larks

      Description

      Steps to reproduce:

      • Use W3C Validator and specify one of our instances like: qa.jtalks.org/jcommune

      AR: The string shortcut is not a registered keyword
      ER: validator doesn't complain about favicon

      Explanation

      According to this resource icons that are marked as <link rel="icon"> are considered as favicons by browsers (the icons that are shown on the browser tab bar near the site name). Historically we could add a word 'shortcut icon' like this:

      <link rel="shortcut icon" type="image/x-icon" href="/jcommune/admin/icon/ico"/>

      The explanation goes like this:

      For historical reasons, the icon keyword may be preceded by the keyword "shortcut". If the "shortcut" keyword is present, it must be come immediately before the icon keyword and the two keywords must be separated by only a single U+0020 SPACE character.

      But now W3C Validator started to complain about it:

      Error: Bad value shortcut icon for attribute rel on element link: The string shortcut is not a registered keyword. The string shortcut is not an absolute URL.

      So we need to get rid of this word, browsers will recognize favicons by 'icon' word. Note, that according to the resource above it's possible to have several favicons and browsers may decide on their own which of them they'd like to use.

        Attachments

          Structure

            Activity

              People

              • Assignee:
                julik Julia Atlygina
                Reporter:
                ctapobep Stanislav Bashkyrtsev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h

                    Structure Helper Panel