[JC-1834] Updating favicon to pass validation - JTalks JIRA

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 2.6 Larks
Fix Version/s: 2.6 Larks
Labels:
None

Sprint:
2.6 Larks

Description

Steps to reproduce:

Use W3C Validator and specify one of our instances like: qa.jtalks.org/jcommune

AR: The string shortcut is not a registered keyword
ER: validator doesn't complain about favicon

Explanation

According to this resource icons that are marked as <link rel="icon"> are considered as favicons by browsers (the icons that are shown on the browser tab bar near the site name). Historically we could add a word 'shortcut icon' like this:

<link rel="shortcut icon" type="image/x-icon" href="/jcommune/admin/icon/ico"/>

The explanation goes like this:

For historical reasons, the icon keyword may be preceded by the keyword "shortcut". If the "shortcut" keyword is present, it must be come immediately before the icon keyword and the two keywords must be separated by only a single U+0020 SPACE character.

But now W3C Validator started to complain about it:

Error: Bad value shortcut icon for attribute rel on element link: The string shortcut is not a registered keyword. The string shortcut is not an absolute URL.

So we need to get rid of this word, browsers will recognize favicons by 'icon' word. Note, that according to the resource above it's possible to have several favicons and browsers may decide on their own which of them they'd like to use.

Attachments

Structure Settings

Structure

(does not include JC-1834)

Activity

Hide

Permalink

Andrey Surzhan added a comment - 25/Mar/14 10:37 PM - edited

Environment: JC 2.6.2122.bdda067 (qa)
Pre-condition:
Go to Jcommune forum
Use http://validator.w3.org/

№	Test	Results
1	Validate HTML of home page	PASS
2	Validate HTML of user's profile pages	PASS
3	Validate HTML of any branch, topic	PASS

Regression tests:
Internet Explorer 11

№	Test	Results
1	Go to home page -appropriate favicon is on tab	PASS
2	Go to user's profile - appropriate favicon is on tab	PASS
3	Go to any branch, topic - appropriate favicon is on tab	PASS
4	Add any page to favorite- appropriate favicon is near bookmark's name	PASS

Google Chrome 33.0.1750.154 m

№	Test	Results
1	Go to home page - appropriate favicon is on tab	PASS
2	Go to user's profile - appropriate favicon is on tab	PASS
3	Go to any branch, topic - appropriate favicon on tab	PASS
4	Add bookmark form any page- appropriate favicon is near bookmark's name	PASS

Firefox 27.0.1

№	Test	Results
1	Go to home page - appropriate favicon is on tab	PASS
2	Go to user's profile - appropriate favicon is on tab	PASS
3	Go to any branch, topic - appropriate favicon is on tab	PASS
4	Add bookmark form any page- appropriate favicon is near bookmark's name	PASS

Note this:

If the shortcut value is omitted from the rel attribute, Internet Explorer ≤ 8 ignores the declaration entirely, searches for a file called favicon.ico in the site root, and uses that instead. In fact, almost every browser does that when there’s no link rel="icon" specified. Using rel="icon shortcut" won’t work in IE either, since it doesn’t treat the rel attribute as a space-separated list.

Source: http://mathiasbynens.be/notes/rel-shortcut-icon
The popular <link rel="shortcut icon" type="image/x-icon" href="favicon.ico" /> theoretically identifies two relations, "shortcut" and "icon", but "shortcut" is not registered and is redundant.

Source: http://en.wikipedia.org/wiki/Favicon

Tests result: Issue can be closed

Show

Andrey Surzhan added a comment - 25/Mar/14 10:37 PM - edited Environment: JC 2.6.2122.bdda067 (qa) Pre-condition: Go to Jcommune forum Use http://validator.w3.org/ № Test Results 1 Validate HTML of home page PASS 2 Validate HTML of user's profile pages PASS 3 Validate HTML of any branch, topic PASS Regression tests: Internet Explorer 11 № Test Results 1 Go to home page -appropriate favicon is on tab PASS 2 Go to user's profile - appropriate favicon is on tab PASS 3 Go to any branch, topic - appropriate favicon is on tab PASS 4 Add any page to favorite- appropriate favicon is near bookmark's name PASS Google Chrome 33.0.1750.154 m № Test Results 1 Go to home page - appropriate favicon is on tab PASS 2 Go to user's profile - appropriate favicon is on tab PASS 3 Go to any branch, topic - appropriate favicon on tab PASS 4 Add bookmark form any page- appropriate favicon is near bookmark's name PASS Firefox 27.0.1 № Test Results 1 Go to home page - appropriate favicon is on tab PASS 2 Go to user's profile - appropriate favicon is on tab PASS 3 Go to any branch, topic - appropriate favicon is on tab PASS 4 Add bookmark form any page- appropriate favicon is near bookmark's name PASS Note this: If the shortcut value is omitted from the rel attribute, Internet Explorer ≤ 8 ignores the declaration entirely, searches for a file called favicon.ico in the site root, and uses that instead. In fact, almost every browser does that when there’s no link rel="icon" specified. Using rel="icon shortcut" won’t work in IE either, since it doesn’t treat the rel attribute as a space-separated list. Source: http://mathiasbynens.be/notes/rel-shortcut-icon The popular <link rel="shortcut icon" type="image/x-icon" href="favicon.ico" /> theoretically identifies two relations, "shortcut" and "icon", but "shortcut" is not registered and is redundant. Source: http://en.wikipedia.org/wiki/Favicon Tests result: Issue can be closed

People

Assignee:

Julia Atlygina

Reporter:

Stanislav Bashkyrtsev

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

24/Mar/14 11:18 PM

Updated:

25/Mar/14 11:53 PM

Resolved:

24/Mar/14 11:24 PM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

0.5h

Structure Helper Panel