Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1846

Improve performance of Move Topic

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7 Larks
    • Fix Version/s: 2.8 Larks
    • Labels:
      None
    • Sprint:
      2.8 Larks, 2.9 Larks

      Description

      As you can see from here:

              Branch targetBranch = branchDao.get(branchId);
              targetBranch.addTopic(topic);
              branchDao.saveOrUpdate(targetBranch);

      We add a topic to the branch which shouldn't happen. The mapping should be inverse=true so that topic saves a link to the branch. Right now the saving of the branch may take awhile because it's probably fetching all the topics from DB.

      If you can find other improvements of Move Topic, feel free to fix them as well.

        Attachments

        1. new_hql.png
          17 kB
          Evgeniy Myslovets
        2. MoveTopics001.jmx
          36 kB
          Artem R
        3. before.png
          18 kB
          Evgeniy Myslovets
        4. autotests-build-2364.jpg
          56 kB
          Artem R
        5. autotests-build-2260.jpg
          57 kB
          Artem R
        6. after.png
          17 kB
          Evgeniy Myslovets

          Issue Links

            Structure

              Activity

                People

                • Assignee:
                  varro Artem R
                  Reporter:
                  ctapobep Stanislav Bashkyrtsev
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 0h
                    0h
                    Remaining:
                    Remaining Estimate - 0h
                    0h
                    Logged:
                    Time Spent - 7h
                    7h

                      Structure Helper Panel