Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1881

Rework Spring Security Patch and send Pull Request

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8 Larks
    • Fix Version/s: 2.10 Larks
    • Labels:
      None
    • Sprint:
      2.10 Larks

      Description

      Intro

      Couple of years ago we've patched Spring Security in order to let it work normally with User Groups. Because it's patched, we cannot update to the newest versions of SS easily.
      A Pull Request was sent to SS and a JIRA issue was created in order for them to merge the change, but according to comments in JIRA - they think the change is too large and they suggest another way to implement it.

      What's needed

      • We need to take the patch and rework it according to SS advise
      • Note, that we've done another change. It shouldn't be sent as a Pull Request, but we need to merge changes together and issue another patched version of SS in order to use it in JTalks until first patch is accepted (second pull request we'll create in the future).
      • We need to check that everything still works with permissions.
      • Afterwards I will merge that change to the existing Pull Request and will update the JIRA.

        Attachments

          Structure

            Activity

              People

              • Assignee:
                QAPasha Paul Panaitov
                Reporter:
                ctapobep Stanislav Bashkyrtsev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 2h
                  2h
                  Logged:
                  Time Spent - 0h
                  0h

                    Structure Helper Panel