-
Type:
Improvement
-
Status: Done (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: common 0.7
-
Fix Version/s: common 0.11
-
Labels:
So instead of having
/**
* Create exception with specific message.
*
* @param message exception message
*/
public DuplicateEmailException(String message) {
super(message);
}
We need this style of exceptions:
public DuplicateEmailException(String email) { this.email = email; super("Email is duplicated [" + email + "]"); }
If you think that user should be allowed to pass a custom error message, then such constructor should be created:
public DuplicateEmailException(String email, String errorMessage)
We don't need the field itself, but the it's better to have more smart implementation of exceptions (any exceptions). This is bad:
public DuplicateEmailException(String message) { super(message); }
because besides we already have the problem described in the exception class, we force the users of this API to specify this info again. This is good:
public DuplicateEmailException(String email) { super("Email is duplicated [" + email + "]"); }
because we ask user to specify only needed information, and we're smart enough to figure out that the problem is in mail duplication (this is class particularly for handling such kind of problems).
also fixed CRLF from windows encoding
spent 2-3 hours
Stas, is it enough to have existing constructor with 2 parameters or do we need to add additional constructor with one parameter?
... like that
{ super("Email is duplicated [" + email + "]"); }public DuplicateEmailException(String email)
why do we need this field in class at all ?