Uploaded image for project: 'JTalks Common'
  1. JTalks Common
  2. JTALKSCOMMON-49

Refactor ACL Builder to be more intuitive

VotersWatchers
    XMLWordPrintable

    Details

      Description

      Currently there are several problems with AclBuilder:

      • It's instantiated inside the methods so it's hard to test those methods, you need to know what does it do with AclManager in order to mock those methods of it.
      • It's not clear from methods' signatures whether the AclBuilder should be reused or not.
      • Since there is no strict order in methods, users can forget to invoke some of them.
      • The methods like
         setOwner()

        are not that clear, we need to stick to more easy-to-read methods.

        Attachments

          Structure

            Activity

              People

              • Assignee:
                ctapobep Stanislav Bashkyrtsev
                Reporter:
                ctapobep Stanislav Bashkyrtsev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4h
                  4h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h
                  4h

                    Structure Helper Panel