-
Type: Improvement
-
Status: Closed (View Workflow)
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: common 0.11
-
Fix Version/s: common 0.11
-
Labels:
Currently there are several problems with AclBuilder:
- It's instantiated inside the methods so it's hard to test those methods, you need to know what does it do with AclManager in order to mock those methods of it.
- It's not clear from methods' signatures whether the AclBuilder should be reused or not.
- Since there is no strict order in methods, users can forget to invoke some of them.
- The methods like
setOwner()
are not that clear, we need to stick to more easy-to-read methods.