Uploaded image for project: 'JTalks Common'
  1. JTalks Common
  2. JTALKSCOMMON-75

Refactoring according to Sonar - Correctness - equals method always returns false

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: common 0.11
    • Fix Version/s: common 0.11
    • Labels:
      None

      Description

      See http://sonar.jtalks.org/drilldown/violations/241?priority=BLOCKER&rids%5B%5D=1309&rule=findbugs%3AEQ_ALWAYS_FALSE#

      • @return always {@code false}

        239
        */
        240
        @Override
        241
        public boolean equals(@Nullable Object object) {
        242
        return false;

      Correctness - equals method always returns false about 1 month
      org.jtalks.common.security.acl.AclUtil$BySidAndPermissionFilter.equals(Object) always returns false

        Attachments

          Structure

            Activity

              People

              • Assignee:
                ancient_mariner Alex Lysak
                Reporter:
                ancient_mariner Alex Lysak
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.15h
                  0.15h

                    Structure Helper Panel