Details

    • Type: Sub-task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13 swallows, 0.14 swallows
    • Fix Version/s: 0.16 swallows
    • Labels:

      Description

      because the old style code doesn't allow to fully use cool features from MVVM and makes code even worse, moving from MVC to MVVM is required

        Attachments

          Activity

          Hide
          demi Leonid Kazantcev added a comment -

          You can look all changes at deploy, i did commit them already.
          Last thing needed for task complition is cover EditComponentVm by tests.

          Show
          demi Leonid Kazantcev added a comment - You can look all changes at deploy, i did commit them already. Last thing needed for task complition is cover EditComponentVm by tests.
          Hide
          ctapobep Stanislav Bashkyrtsev added a comment - - edited

          You were mentioning the problem with onOK event for the window - that it doesn't work. But I don't see any attempts to implement onOK for the window, it's just not there.
          Also, please, remove ComponentType.ANTARCTICLE, we don't need it for now. We'll add it back when it's needed.
          PS: update the remaining time.

          Show
          ctapobep Stanislav Bashkyrtsev added a comment - - edited You were mentioning the problem with onOK event for the window - that it doesn't work. But I don't see any attempts to implement onOK for the window, it's just not there. Also, please, remove ComponentType.ANTARCTICLE, we don't need it for now. We'll add it back when it's needed. PS: update the remaining time.
          Hide
          ctapobep Stanislav Bashkyrtsev added a comment -

          While configuring JCommune:

          • There is no default value for Post Preview Size
          • If I specify a wrong value for some of fields, it shows a popup, but anyway closes window on Save. Though it shouldn't (probably a Form Binding is not specified on the page).
          Show
          ctapobep Stanislav Bashkyrtsev added a comment - While configuring JCommune: There is no default value for Post Preview Size If I specify a wrong value for some of fields, it shows a popup, but anyway closes window on Save. Though it shouldn't (probably a Form Binding is not specified on the page).
          Hide
          demi Leonid Kazantcev added a comment -

          Your notes fixed.

          Show
          demi Leonid Kazantcev added a comment - Your notes fixed.
          Hide
          julik Julia Atlygina added a comment -

          hard to test except regression tests; regression will be done with another issue (http://jira.jtalks.org/browse/POULPE-108)

          Show
          julik Julia Atlygina added a comment - hard to test except regression tests; regression will be done with another issue ( http://jira.jtalks.org/browse/POULPE-108 )

            People

            • Assignee:
              julik Julia Atlygina
              Reporter:
              ifchy Ivaylo Kasaivanov
            • Votes:
              0 Vote for this issue
              Watchers:
              Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 6h Original Estimate - 6h
                6h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 44h 19m
                44h 19m

                  Structure Helper Panel