JCommuneIcon indicating the project type

JCommune

Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1640

JCommune should use %20 instead of spaces in url

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.5 Larks
    • Fix Version/s: 2.5 Larks
    • Labels:
      None
    • Sprint:
      2.4 Larks, 2.5 Larks

      Description

      Steps to reproduce
      Validate page http://qa.jtalks.org/jcommune/plugins/list with W3C validator

      Actual result
      Validator show error:

      Line 1, Column 10727: Bad value /jcommune/plugins/configure/Poulpe Auth Plugin for attribute href on element a: Whitespace in path component. Use %20 in place of spaces.

      Expected result
      There is no errors

        Attachments

        1. spaces.png
          333 kB
          Oksana Chuiko
        2. Spaces in url.jpg
          102 kB
          Artem R

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JC-1627 HTML errors

          • Major - Major loss of function.
          • Closed

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. JC-1497 Poulpe Auth Plugin

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JC-1687 Spaces in "url" and "img" bb-codes should be encoded as %20

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents the functions of the product. JC-1725 Validation errors in admin mode

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            33 older comments
            Hide
            Permalink
            ctapobep Stanislav Bashkyrtsev added a comment -

            And this is done because..? Does it violate validation rules?
            Let's suppose it does actually violate - then it means that every page should use this tag. And didn't you try to find other ways, maybe configuring spring tag? E.g. if you change UTF-8 to something else, you'll get different encoding and + will probably be replaced.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - And this is done because..? Does it violate validation rules? Let's suppose it does actually violate - then it means that every page should use this tag. And didn't you try to find other ways, maybe configuring spring tag? E.g. if you change UTF-8 to something else, you'll get different encoding and + will probably be replaced.
            Hide
            Permalink
            ctapobep Stanislav Bashkyrtsev added a comment -

            Andrey Pogorelov, please review the changes.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - Andrey Pogorelov , please review the changes.
            Hide
            Permalink
            sptp Andrey Pogorelov added a comment -

            Review done: http://fisheye.jtalks.org/cru/JC-201#CFR-7166
            I think spring:url works fine, result:

            <form id="pluginConfiguration" action="/plugins/configure/Poulpe%20Auth%20Plugin" method="POST">
            Show
            sptp Andrey Pogorelov added a comment - Review done: http://fisheye.jtalks.org/cru/JC-201#CFR-7166 I think spring:url works fine, result: <form id= "pluginConfiguration" action= "/plugins/configure/Poulpe%20Auth%20Plugin" method= "POST" >
            Hide
            Permalink
            nigredo Andrey Ivanov added a comment -

            Done!

            Show
            nigredo Andrey Ivanov added a comment - Done!
            Hide
            Permalink
            varro Artem R added a comment - - edited

            Test Environment
            W3C validator, Firefox, Chrome, JCommune 2.5.2037.944093a

            Test Scenario #1
            Preconditions
            User has admin permissions, user is logged in

            Steps
            1. Open Administration - Plugins
            2. Select Poulpe Auth Plugin - Configure.
            3. Validate page via W3C validator (using direct input)

            Actual result = Expected result
            Page is valid

            Test Scenario #2
            Preconditions
            User has admin permissions, user is logged in

            Steps
            1. Open Administration - Plugins
            2. Select Poulpe Auth Plugin - Configure.
            3. Go to Administration - Administration mode
            4. Validate page via W3C validator (using direct input)

            Actual result = Expected result
            Page is valid

            Regression tests:
            Page with plugin list, Kaptcha configuring page are valid in admin and not admin mode.

            Test results:
            Issue can be closed

            Show
            varro Artem R added a comment - - edited Test Environment W3C validator , Firefox, Chrome, JCommune 2.5.2037.944093a Test Scenario #1 Preconditions User has admin permissions, user is logged in Steps 1. Open Administration - Plugins 2. Select Poulpe Auth Plugin - Configure. 3. Validate page via W3C validator (using direct input) Actual result = Expected result Page is valid Test Scenario #2 Preconditions User has admin permissions, user is logged in Steps 1. Open Administration - Plugins 2. Select Poulpe Auth Plugin - Configure. 3. Go to Administration - Administration mode 4. Validate page via W3C validator (using direct input) Actual result = Expected result Page is valid Regression tests: Page with plugin list, Kaptcha configuring page are valid in admin and not admin mode. Test results: Issue can be closed

              People

              • Assignee:
                varro Artem R
                Reporter:
                varro Artem R
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4.5h
                  4.5h

                    Structure Helper Panel