Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-1706

XSS in adding external link dialog

VotersWatchers
    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3 Larks
    • Fix Version/s: 2.4 Larks
    • Labels:
    • Sprint:
      2.4 Larks

      Description

      Steps to reproduce
      1. Log in with permissions to edit external links.
      2. Go to external links editor
      3. Press "Add" button
      4. Fill all fields with

      <script>alert("Ha")<script>

      5. Press "Save" button
      IMPORTANT!!
      do not close external link popup window unless you have DB access
      6. Open JCommune main page in new tab.

      Actual result

      1. Window with link editor isn't closed
      2. Layout is broken (see screenshot)
      3. If user adds one more link - there is link with "data-original-title" title in link list.

      Expected result
      URL should be escaped when the page is rendered so that its symbols are not considered as special.

        Attachments

          Issue Links

            Structure

              Activity

                People

                • Assignee:
                  varro Artem R
                  Reporter:
                  varro Artem R
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0h
                    0h
                    Logged:
                    Time Spent - 2h
                    2h

                      Structure Helper Panel