-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3 Larks
-
Fix Version/s: 2.4 Larks
-
Labels:
-
Sprint:2.4 Larks
Steps to reproduce
1. Log in with permissions to edit external links.
2. Go to external links editor
3. Press "Add" button
4. Fill all fields with
<script>alert("Ha")<script>
5. Press "Save" button
IMPORTANT!!
do not close external link popup window unless you have DB access
6. Open JCommune main page in new tab.
Actual result
- Window with link editor isn't closed
- Layout is broken (see screenshot)
- If user adds one more link - there is link with "data-original-title" title in link list.
Expected result
URL should be escaped when the page is rendered so that its symbols are not considered as special.
- relates to
-
JC-1667 Refactor External Links dialog to create Title, Hint, Href inputs
-
- Closed
-
method didn/t escape quotes
Pavel Vervenko, could you please review?
small fix to encode.
task is done
Test Environment
JCommune 2.3.1852.4ff5f60, Firefox, Chrome
Test Scenario #1
Steps
1. Go to external links editor and press "Add new link" button
2. Fill all fields with
<script>alert("Ha")<script>
3. Press "Save" button
Actual result = Expected result
All fields are correctly filled, layout displays as expected.
Test Scenario #2
Steps
1. Go to external links editor and press "Add new link" button
2. Fill all fields with
</a></span></span></div>
3. Press "Save" button
Actual result = Expected result
All fields are correctly filled, layout displays as expected.
Regression tests:
Adding correct external links, changing forum configuration works as expected.
Test results:
Issue can be closed
Stanislav Koval, why did you move back to your own custom methods? What was wrong with the existing one?