Uploaded image for project: 'JCommune'
  1. JCommune
  2. JC-2035

UI: Change Topic Type button locate under Create Button

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.13 Larks
    • Fix Version/s: 2.13 Larks
    • Labels:
    • Sprint:
      2.13 Larks

      Description

      Scenario 1: There are two buttons (Create Topic and Select topic) instead of 1

      Steps to reproduce

      1. Select some branch
        • You shouldn't have permission CREATE_POSTS in this branch
        • Assign CREATE_CODE_REVIEW, CREATE_QUESTION permissions
      2. Open this branch as logged in user, English language should be selected

      Actual result: Change Topic Type button is located under Create button, it looks like two elements.
      Expected result: Change Topic Type button is located to the right of the Create button, it looks like a single element.

      Same problem if you assign select Russian, Ukrainian or Spanish language and more than 1 permission from the list: CREATE_POSTS, CREATE_CODE_REVIEW, CREATE_QUESTION

      ---------------------------------------

      Scenario 2: Create topic button becomes just blue ellipse

      Steps to reproduce:

      1. Select branch
        • You shouldn't have CREATE_POSTS, CREATE_CODE_REVIEW permissions
        • You should have CREATE_QUESTION permission
      2. open this branch as logged in user

      Actual result: top Create Question button is unnamed and don't looks good (see screen)
      Expected result: top Create Question button have name and looks good.

        Attachments

        1. Scenario 1.png
          Scenario 1.png
          19 kB
        2. Scenario 2.png
          Scenario 2.png
          28 kB
        3. Scenario 3.png
          Scenario 3.png
          56 kB

          Issue Links

            Activity

            Hide
            jenkins Jenkins Bot added a comment -

            SUCCESS: Integrated in JC. Unit Tests #2658
            #JC-2035 Fixed problems with the create topic buttons layout: (aa.ramone: 85824d10649e22598b710a21a0964e6cab2bba54)

            Show
            jenkins Jenkins Bot added a comment - SUCCESS: Integrated in JC. Unit Tests #2658 # JC-2035 Fixed problems with the create topic buttons layout: (aa.ramone: 85824d10649e22598b710a21a0964e6cab2bba54 )
            Hide
            julik Julia Atlygina added a comment -

            Dmitriy Gurduz please pay attention to CI before testing

            Show
            julik Julia Atlygina added a comment - Dmitriy Gurduz please pay attention to CI before testing
            Hide
            julik Julia Atlygina added a comment -

            delivered to QA instance, you can test it

            Show
            julik Julia Atlygina added a comment - delivered to QA instance, you can test it
            Hide
            Dmitriy Dmitriy Gurduz (Inactive) added a comment -

            Test Environment:

            • Build: 2.13.2658.85824d1 (QA)
            • Browsers: Firefox 33.1, Google Chrome 39.0, Opera 26.0

            Scenario 1
            Steps to reproduce

            1. Select some branch
              • You shouldn't have permission CREATE_POSTS in this branch
              • Assign CREATE_CODE_REVIEW, CREATE_QUESTION permissions
            2. Open this branch as logged in user, English (Russian, Ukrainian, Spanish) language should be selected

            AR=ER: Change Topic Type button is located to the right of the Create button, it looks like a single element.
            Attachments for English: http://screencast.com/t/DEgq0vjmW
            Attachments for Russian: http://screencast.com/t/OTqLcgloDg
            Attachments for Ukrainian: http://screencast.com/t/e1tllqBiC2M
            Attachments for Spanish: http://screencast.com/t/yUK8AsNfuJc

            Scenario 2
            Steps to reproduce:

            1. Select branch
              • You shouldn't have CREATE_POSTS, CREATE_CODE_REVIEW permissions
              • You should have CREATE_QUESTION permission
            2. Open this branch as logged in user

            AR=ER: top Create Question button have name and looks good.
            Attachments: http://screencast.com/t/CNu3FiY7dxa

            Regression tests:

            Test Result
            1 Possibility to create new topic http://jira.jtalks.org/browse/QA-894 PASS
            2 User can change Topic Type when assigned more than 1 permission from the list: CREATE_POSTS, CREATE_CODE_REVIEW, CREATE_QUESTION PASS
            3 Change Topic Type button is located to the right of the Create button on small screen (http://jira.jtalks.org/browse/JC-2025) PASS
            4 Top Create Question button have name and looks good on small screen (http://jira.jtalks.org/browse/JC-2025) PASS
            5 Top Create Question button have name and looks good when user selected English (Russian, Ukrainian, Spanish) language PASS
            6 Top Create Topic button have name and looks good PASS
            7 Top Create Code Review button have name and looks good PASS
            8 Possibility to create new topic http://jira.jtalks.org/browse/QA-894 PASS
            9 Change Topic Type button is located to the right of the Create button when you CREATE_POSTS, CREATE_CODE_REVIEW and CREATE_QUESTION permissions PASS

            Tests result: Issue can be closed

            Show
            Dmitriy Dmitriy Gurduz (Inactive) added a comment - Test Environment : Build: 2.13.2658.85824d1 (QA) Browsers: Firefox 33.1, Google Chrome 39.0, Opera 26.0 Scenario 1 Steps to reproduce Select some branch You shouldn't have permission CREATE_POSTS in this branch Assign CREATE_CODE_REVIEW, CREATE_QUESTION permissions Open this branch as logged in user, English (Russian, Ukrainian, Spanish) language should be selected AR=ER : Change Topic Type button is located to the right of the Create button, it looks like a single element. Attachments for English: http://screencast.com/t/DEgq0vjmW Attachments for Russian: http://screencast.com/t/OTqLcgloDg Attachments for Ukrainian: http://screencast.com/t/e1tllqBiC2M Attachments for Spanish: http://screencast.com/t/yUK8AsNfuJc Scenario 2 Steps to reproduce : Select branch You shouldn't have CREATE_POSTS, CREATE_CODE_REVIEW permissions You should have CREATE_QUESTION permission Open this branch as logged in user AR=ER : top Create Question button have name and looks good. Attachments: http://screencast.com/t/CNu3FiY7dxa Regression tests : № Test Result 1 Possibility to create new topic http://jira.jtalks.org/browse/QA-894 PASS 2 User can change Topic Type when assigned more than 1 permission from the list: CREATE_POSTS, CREATE_CODE_REVIEW, CREATE_QUESTION PASS 3 Change Topic Type button is located to the right of the Create button on small screen ( http://jira.jtalks.org/browse/JC-2025 ) PASS 4 Top Create Question button have name and looks good on small screen ( http://jira.jtalks.org/browse/JC-2025 ) PASS 5 Top Create Question button have name and looks good when user selected English (Russian, Ukrainian, Spanish) language PASS 6 Top Create Topic button have name and looks good PASS 7 Top Create Code Review button have name and looks good PASS 8 Possibility to create new topic http://jira.jtalks.org/browse/QA-894 PASS 9 Change Topic Type button is located to the right of the Create button when you CREATE_POSTS, CREATE_CODE_REVIEW and CREATE_QUESTION permissions PASS Tests result : Issue can be closed

              People

              • Assignee:
                Dmitriy Dmitriy Gurduz (Inactive)
                Reporter:
                terracott Denis Kajgorodov
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Structure Helper Panel